Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix misalignment of "powered by" brand link #5496

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Fix misalignment of "powered by" brand link #5496

merged 2 commits into from
Nov 14, 2024

Conversation

jpople
Copy link
Contributor

@jpople jpople commented Nov 14, 2024 •
edited by gilluminate
Loading

Closes HJ-205

Description Of Changes

Fixes a bug where the "powered by" brand link was misaligned when the consent modal didn't have a language picker or privacy policy link.

Before:
Screenshot 2024-11-14 at 15 24 14

After:

Screenshot 2024-11-14 at 15 25 24

With language picker and privacy policy link:

Screenshot 2024-11-14 at 15 27 20

Code Changes

  • Add a new classname to the modal secondary button group and enforce a min-height (as we do for the language picker) when showFidesBrandLink is true

Steps to Confirm

  1. View the consent modal for an experience with a

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel Vercel
Copy link

vercel bot commented Nov 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Nov 14, 2024 9:29pm

@cypress Cypress
Copy link

cypress bot commented Nov 14, 2024 •
edited
Loading

fides    Run #11014

Run Properties:  status check passed Passed #11014  •  git commit ac5ca90c4f ℹ️: Merge 5cd0e02ee75e0e308e9fa777735b5944c3b5bc34 into 00d54c89607be13a237c7e56eedf...
Project fides
Branch Review refs/pull/5496/merge
Run status status check passed Passed #11014
Run duration 00m 40s
Commit git commit ac5ca90c4f ℹ️: Merge 5cd0e02ee75e0e308e9fa777735b5944c3b5bc34 into 00d54c89607be13a237c7e56eedf...
Committer jpople
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

gilluminate
gilluminate approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@gilluminate gilluminate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and looks much better. Approved
CleanShot 2024-11-14 at 14 45 21@2x

@jpople jpople merged commit 1c8b2d7 into main Nov 14, 2024
13 checks passed
@jpople jpople deleted the jpople/hj-201/powered-by-alignment-fix branch November 14, 2024 21:47
jpople added a commit that referenced this pull request Nov 14, 2024
@jpople
Fix misalignment of "powered by" brand link (#5496)
b4ade8c
@cypress Cypress
Copy link

cypress bot commented Nov 14, 2024

fides    Run #11015

Run Properties:  status check passed Passed #11015  •  git commit 1c8b2d74db: Fix misalignment of "powered by" brand link (#5496)
Project fides
Branch Review main
Run status status check passed Passed #11015
Run duration 00m 40s
Commit git commit 1c8b2d74db: Fix misalignment of "powered by" brand link (#5496)
Committer jpople
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gilluminate gilluminate gilluminate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpople @gilluminate